linux-kernel - Re: [PATCH] dmaengine: remove redundant null check on req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4iD5xD8E3E9+gbgmrbD+nNpXfjMqi4WzTA46H9mSv5gvQ@mail.gmail.com>
Date:   Wed, 17 May 2017 12:12:00 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Anup Patel <anup.patel@...adcom.com>,
        Vinod Koul <vinod.koul@...el.com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: remove redundant null check on req

On Wed, May 17, 2017 at 6:35 AM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Req is never null on at the point of the null check, so
> remove this redundant check and just return &req->tx.
>
> Detected by CoverityScan, CID#1436147 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Hi Colin,

Looks good, can you also include the driver name in your patch subjects?

For example "dmaengine, bcm-scm-raid: remove redundant null check on
req", would make it clear that this is a driver fix and not a core
dmaengine issue.