linux-kernel - Re: [RFC][PATCHSET] wait4()/waitid() cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87efvn9rza.fsf@xmission.com>
Date:   Wed, 17 May 2017 14:57:13 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Christoph Hellwig <hch@....de>
Subject: Re: [RFC][PATCHSET] wait4()/waitid() cleanups

Al Viro <viro@...IV.linux.org.uk> writes:

> 	This series switches compat wait4() and waitid() variants away
> from set_fs() use.  A couple of helpers (kernel_wait4() and kernel_waitid())
> are introduced, copying siginfo/rusage to userland is taken to sys_wait...().
> That allows both to simplify the guts of do_wait() machinery and avoid
> messing with set_fs() in compat variants of these syscalls.
>
> 	Lightly tested, seems to survive without regressions.  Please,
> review.

A quick heads up.  I have a patchset that is almost ready to go that is
also extensively touching wait.  The point of that patchset is to get
the logic correct in the intersection ptrace, threads, signals, and wait.

As an example of things that are obviously wrong today.  In the case of
a ptrace stop we can set si_code to either  CLD_STOPPED or CLD_TRAPPED
but in waitid we always return for the same set of conditions
CLD_TRAPPED.

I don't believe we have any fundamental conflicts but if we aren't
careful we could have a nasty merge conflict.

Eric