linux-kernel - Re: Build warning 'uninitialized variable' in fs/overlayfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOQ4uxj=_MrGzwNmxcjj61ZjUUCackxM=1yurD+uGDxtjU4SRg@mail.gmail.com>
Date:   Thu, 18 May 2017 01:17:05 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Yury Norov <ynorov@...iumnetworks.com>
Cc:     Miklos Szeredi <mszeredi@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Build warning 'uninitialized variable' in fs/overlayfs

On Wed, May 17, 2017 at 11:26 PM, Yury Norov <ynorov@...iumnetworks.com> wrote:
> Hi Amir,
>
> (Sorry for new email, but I cannot find your patch in my mailbox,
> though found it in next-20170517)
>
> Your patch 02cac3227a282 (ovl: mark upper dir with type origin entries
> "impure") makes gcc warn on uninitialized variables in my arm64 build:
> fs/overlayfs/dir.c: In function ‘ovl_rename’:
> fs/overlayfs/dir.c:1060:2: warning: ‘newdentry’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> dput(newdentry);
> ^~~~~~~~~~~~~~~
> fs/overlayfs/dir.c:1062:2: warning: ‘olddentry’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> dput(olddentry);
> ^~~~~~~~~~~~~~~
>
> The patch below fixes warnings for me. But I'm not familiar to the
> subsystem and so not sure that the fix is correct.
>
It's not. Should be goto out_revert_creds;

Already sent a fix for that.
Thanks!