linux-kernel - Re: [PATCH v2 00/18] ARM64: meson: DT cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 May 2017 15:34:05 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     Andreas Färber <afaerber@...e.de>
Cc:     Neil Armstrong <narmstrong@...libre.com>,
        linux-amlogic@...ts.infradead.org, Rob Herring <robh@...nel.org>,
        devicetree@...r.kernel.org,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-kernel@...r.kernel.org, Carlo Caione <carlo@...one.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 00/18] ARM64: meson: DT cleanups

Hi Andreas,

Andreas Färber <afaerber@...e.de> writes:

> Am 15.05.2017 um 10:16 schrieb Neil Armstrong:

[...]

>> 
>> It's not perfect, but now it's done, live with it, this has already been discussed.
>
> No.
>
> Copy&pasting your comment N times does not make it any more valid. My
> files, my rules - I insist on vega-s95, gxbb and gx, which you guys
> refactored out from my gxbb, to be tidy.

hmm, "my files, my rules, ... my gxbb"

Very interesting perspective, but sorry, these do not belong to you.
They belong to the kernel community.  You can insist if you like, but we
do not make decisions just because someone says "mine".  Again, the
confrontaional tone is not helpful to the dialogue.

[...]

>> 
>> Well, this is why we have 7 rc releases after the merge window...
>
> If Kevin is the maintainer, then he needs to carefully review patches.

Thank you for implying that I don't carefully review patches.  You're
winning me over. :(

Please see my reply to the cover letter as to why this kind of thing has
not been on my priority list of things I look for during review.

> It is not my job to review all patches when BayLibre gets paid for it!

You have no idea who is getting paid for what kind of work, so please
don't make decisions about what you review based on your assumptions.

[...]

> I will also remind that I was forced to clean up the node order in ALL
> exynos5250 .dts files before I could get my new exynos5250-spring.dts
> merged, so I have zero understanding about these "churn" and "live with
> it" comments here. The same rules need to apply to all

It's a nice ideal that the same rules would apply to all, and in some
areas of the kernel, it may be true.  However, in actual practice,
across the variety of kernel subsystems and platforms, there are in fact
a rather large variety of "rules" with a huge amount of discretion left
up to the maintainers.

While that is a point of endless frustration for some (many?) it's also
part of what makes the kernel community healthy, vibrant and still
alive.

Look, you convinced me based on sound technical arguments, good code,
well written changelogs and persistence, even in spite of your
accusatory tone and insinuations.

For future reference, I'd be much happier to review without the latter.

Thanks,

Kevin