linux-kernel - Re: [PATCH] Staging: media: fix missing blank line coding style issue in atomisp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1495125080.7848.63.camel@linux.intel.com>
Date:   Thu, 18 May 2017 17:31:20 +0100
From:   Alan Cox <alan@...ux.intel.com>
To:     Manny Vindiola <mannyv@...il.com>, mchehab@...nel.org,
        gregkh@...uxfoundation.org
Cc:     linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: media: fix missing blank line coding style
 issue in atomisp_tpg.c

On Wed, 2017-05-17 at 21:48 -0400, Manny Vindiola wrote:
> This is a patch to the atomisp_tpg.c file that fixes up a missing
> blank line warning found by the checkpatch.pl tool
> 
> Signed-off-by: Manny Vindiola <mannyv@...il.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> index 996d1bd..48b9604 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> @@ -56,6 +56,7 @@ static int tpg_set_fmt(struct v4l2_subdev *sd,
>  		       struct v4l2_subdev_format *format)
>  {
>  	struct v4l2_mbus_framefmt *fmt = &format->format;
> +
>  	if (format->pad)
>  		return -EINVAL;
>  	/* only raw8 grbg is supported by TPG */

The TODO fille for this driver specifically says not to send formatting
patches at this point.

There is no point making trivial spacing changes in code that needs
lots of real work. It's like polishing your car when the doors have
fallen off.

Alan