linux-kernel - Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALcN6mgWF+Eb-yjZy_BbQoMUYKBj2YVXpj4x8AeYD9Q=+o--Lg@mail.gmail.com>
Date:   Thu, 18 May 2017 11:29:37 -0700
From:   David Carrillo-Cisneros <davidcc@...gle.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>, Simon Que <sque@...omium.org>,
        Wang Nan <wangnan0@...wei.com>, Jiri Olsa <jolsa@...nel.org>,
        He Kuang <hekuang@...wei.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        David Ahern <dsa@...ulusnetworks.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode

On Thu, May 18, 2017 at 9:13 AM, Jiri Olsa <jolsa@...hat.com> wrote:
> On Wed, May 17, 2017 at 09:16:02PM -0700, David Carrillo-Cisneros wrote:
>
> SNIP
>
>>
>> @@ -2107,42 +2109,80 @@ struct feature_ops {
>>       int (*process)(struct feat_fd *fd, void *data);
>>       const char *name;
>>       bool full_only;
>> +     int record_type;
>>  };
>>
>> -#define FEAT_OPA(n, func) \
>> -     [n] = { .name = #n, .write = write_##func, .print = print_##func }
>> -#define FEAT_OPP(n, func) \
>> -     [n] = { .name = #n, .write = write_##func, .print = print_##func, \
>> -             .process = process_##func }
>> -#define FEAT_OPF(n, func) \
>> -     [n] = { .name = #n, .write = write_##func, .print = print_##func, \
>> -             .process = process_##func, .full_only = true }
>> +#define FEAT_OPP(n, func, __full_only) \
>> +     [HEADER_##n] = {                                        \
>> +             .name = __stringify(HEADER_##n),                \
>> +             .write = write_##func,                          \
>> +             .print = print_##func,                          \
>> +             .full_only = __full_only,                       \
>> +             .process = process_##func,                      \
>> +             .record_type = PERF_RECORD_HEADER_##n           \
>> +     }
>> +
>> +#define FEAT_OPN(n, func, __full_only) \
>> +     [HEADER_##n] = {                                        \
>> +             .name = __stringify(HEADER_##n),                \
>> +             .write = write_##func,                          \
>> +             .print = print_##func,                          \
>> +             .full_only = __full_only,                       \
>> +             .process = process_##func                       \
>> +     }
>
> you're adding record_type, which should not be a reason
> to rename FEAT_* macros.. please do that in the separate
> patch and state reason in changelog

will do