linux-kernel - Re: [PATCH] ring-buffer: Remove unused function __rb_data_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170518154643.4306b37d@gandalf.local.home>
Date:   Thu, 18 May 2017 15:46:43 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Matthias Kaehlcke <mka@...omium.org>,
        Ingo Molnar <mingo@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ring-buffer: Remove unused function
 __rb_data_page_index()

On Thu, 18 May 2017 12:40:02 -0700
Doug Anderson <dianders@...omium.org> wrote:

> Hi,
> 
> This appears to have been introduced in 2009 by commit afbab76a62b6
> ("ring-buffer: have read page swap increment counter with page
> entries"), which removed the user of the function but not the function
> itself.  If folks were so inclined, this could be picked back to
> linux-stable, but I'm not sure it's worth it.

It doesn't do anything but waste some disk space in the source
repository. It's a static inline function, which means it's not created
unless something calls it.

Thus, not worth the stable churn.

-- Steve