linux-kernel - Re: [PATCH 7/8] clocksource/drivers/fttmr010: Merge Moxa into FTTMR010

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92ab6fb5-7c4a-0909-ee5b-f573751427fa@kaod.org>
Date:   Thu, 18 May 2017 23:09:06 +0200
From:   Cédric Le Goater <clg@...d.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Joel Stanley <joel@....id.au>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jonas Jensen <jonas.jensen@...il.com>,
        Janos Laube <janos.dev@...il.com>,
        Paulius Zaleckas <paulius.zaleckas@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Ryan Chen <ryan_chen@...eedtech.com>
Subject: Re: [PATCH 7/8] clocksource/drivers/fttmr010: Merge Moxa into
 FTTMR010

On 05/18/2017 10:20 PM, Linus Walleij wrote:
> On Thu, May 18, 2017 at 2:43 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
>> On Thu, May 18, 2017 at 9:22 AM, Joel Stanley <joel@....id.au> wrote:
>>> On Wed, May 17, 2017 at 10:05 PM, Linus Walleij
>>> <linus.walleij@...aro.org> wrote:
>>>> This merges the Moxa Art timer driver into the Faraday FTTMR010
>>>> driver and replaces all Kconfig symbols to use the Faraday
>>>> driver instead. We are now so similar that the drivers can
>>>> be merged by just adding a few lines to the Faraday timer.
>>>
>>> Nice work!
>>>
>>> I gave this a spin on hardware and it didn't work :(
>>
>> How typical.
> 
> I sent a v2 patch set.
> 
> I couldn't get qemu to work because Fedora's QEMU is not
> up-to-date and I didn't want to venture into compiling from source...
> 
> I did the second best and tested Gemini with downward counting
> timers, after just adding that as general code path in the driver
> in the commit merging the two drivers.
> 
> Please test it, and I hope I'm not wasting too much of your time :/
> 
> If it still doesn't work I guess I have to try to get qemu going.
> 
> The fttmr010 branch in my git is updated:
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git/

So a real AST2500 evb board boot fines with this branch but the timer 
model in QEMU crashes miserably :

	[    0.000000] NR_IRQS:16 nr_irqs:16 16
	Floating point exception (core dumped)

that is just before :

	[    0.000000] clocksource: FTTMR010-TIMER2: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 77222644334 ns
	[    0.000025] sched_clock: 32 bits at 24MHz, resolution 40ns, wraps every 86767015915ns

Something to look at in QEMU.

Joel, do you confirm ? 

Thanks,

C.