linux-kernel - Re: [RESEND PATCH v3] sched/deadline: Remove unnecessary condition in push_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170518081213.3phqkffs6cvjurlt@e106622-lin>
Date:   Thu, 18 May 2017 09:12:13 +0100
From:   Juri Lelli <juri.lelli@....com>
To:     Byungchul Park <byungchul.park@....com>
Cc:     peterz@...radead.org, linux-kernel@...r.kernel.org,
        kernel-team@....com, rostedt@...dmis.org, bristot@...hat.com
Subject: Re: [RESEND PATCH v3] sched/deadline: Remove unnecessary condition
 in push_dl_task()

Hi,

On 18/05/17 11:00, Byungchul Park wrote:
> On Fri, May 12, 2017 at 10:05:59AM +0900, Byungchul Park wrote:
> > pick_next_pushable_dl_task(rq) has BUG_ON(rq->cpu != task_cpu(task))
> > when it returns a task other than NULL, which means that task_cpu(task)
> > must be rq->cpu. So if task == next_task, then task_cpu(next_task) must
> > be rq->cpu as well. Remove the redundant condition and make code simpler.
> > 
> > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > statement can be avoided.
> 
> +cc rostedt@...dmis.org
> +cc juri.lelli@....com
> +cc bristot@...hat.com
> 
> > 
> > Signed-off-by: Byungchul Park <byungchul.park@....com>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> > Reviewed-by: Juri Lelli <juri.lelli@....com>

It looked, and still looks, good to me. :)

Thanks,

- Juri