linux-kernel - Re: [PATCH] staging: iio: light: Replace symbolic permissions as per coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 May 2017 11:06:03 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     surenderpolsani@...il.com
Cc:     jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, gregor.boirie@...rot.com,
        devel@...verdev.osuosl.org, eraretuya@...il.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        maitysanchayan@...il.com, singhalsimran0@...il.com
Subject: Re: [PATCH] staging: iio: light: Replace symbolic permissions as per
 coding style

On Thu, May 18, 2017 at 02:06:29PM +0530, surenderpolsani@...il.com wrote:
> From: Surender Polsani <surenderpolsani@...il.com>
> 
> Fixed the following checkpatch.pl warnings:
> octal permissions are more preferable than symbolic permissions
> 
> Signed-off-by: Surender Polsani <surenderpolsani@...il.com>
> ---
>  drivers/staging/iio/light/tsl2x7x_core.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index af3910b..c63fe6a 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -1498,34 +1498,34 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
>  	return 0;
>  }
>  
> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
> +static DEVICE_ATTR(power_state, 0644,
>  		tsl2x7x_power_state_show, tsl2x7x_power_state_store);

How about using DEVICE_ATTR_RW() and DEVICE_ATTR_RO() instead?

thanks,

greg k-h