linux-kernel - Re: [PATCH v2 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170518092630.GA28006@infradead.org>
Date:   Thu, 18 May 2017 02:26:30 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Gabriele Paoloni <gabriele.paoloni@...wei.com>
Cc:     bhelgaas@...gle.com, helgaas@...nel.org, linuxarm@...wei.com,
        linux-pci@...r.kernel.org, lukas@...ner.de,
        linux-kernel@...r.kernel.org, mika.westerberg@...ux.intel.com,
        hch@...radead.org, liudongdong3@...wei.com
Subject: Re: [PATCH v2 1/2] PCI/portdrv: add support for different MSI
 interrupts for PCIe port services

> - * pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port
> + * pcie_port_enable_msix_or_msi - try to set up MSI-X or MSI as interrupt mode
> + * for given port

just rename it to pcie_port_enable_vecs to avoid the overly long line..

> +		 * pci_irq_vector() below is able to handle entry differently
> +		 * depending on MSI vs MSI-x case

As mentioned in the review for the other patch:  no need to repeat
this for every user of pci_irq_vector.

Otherwise this looks fine to me:

Reviewed-by: Christoph Hellwig <hch@....de>