linux-kernel - Re: [PATCH linux-next v2 1/1] spi: imx: dynamic burst length adjust for PIO mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 May 2017 12:29:54 +0300
From:   Leonard Crestez <leonard.crestez@....com>
To:     Jiada Wang <jiada_wang@...tor.com>
CC:     <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Octavian Purdila <octavian.purdila@....com>,
        "Fabio Estevam" <fabio.estevam@....com>,
        Robin Gong <yibin.gong@....com>
Subject: Re: [PATCH linux-next v2 1/1] spi: imx: dynamic burst length adjust
 for PIO mode

On Wed, 2017-05-17 at 18:50 -0700, Jiada Wang wrote:
> Hello Leonard
> 
> Thanks for the report, can you help to check if the following change 
> address the issue?
> 
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 782045f..19b30cf 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -288,6 +288,9 @@ static void spi_imx_u32_swap_u8(struct spi_transfer 
> *transfer, u32 *buf)
>   {
>          int i;
> 
> +       if (!buf)
> +               return;
> +
>          for (i = 0; i < transfer->len / 4; i++)
>                  *(buf + i) = cpu_to_be32(*(buf + i));
>   }
> @@ -296,6 +299,9 @@ static void spi_imx_u32_swap_u16(struct spi_transfer 
> *transfer, u32 *buf)
>   {
>          int i;
> 
> +       if (!buf)
> +               return;
> +
>          for (i = 0; i < transfer->len / 4; i++) {
>                  u16 *temp = (u16 *)buf;
> 

Yes, this does seem to fix it.