linux-kernel - Re: [PATCH v3 1/2] lib/btree.c: optimise the code by previously getpos function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfiX_N-RmrZKXzdXVRyPWx2jQM3HjiogCcC2D2mi0H7Bg@mail.gmail.com>
Date:   Thu, 18 May 2017 12:50:39 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Leno Hou <lenohou@...il.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3 1/2] lib/btree.c: optimise the code by previously
 getpos function

On Thu, May 18, 2017 at 11:35 AM, Leno Hou <lenohou@...il.com> wrote:
> Rework the getpos() helper function and use it to remove various
> open-coded implemetnations of its funtionality.
>
> v2 -> v3:
>   - getfill() returns no entry if not found the fill position
>
> v1 -> v2:
>   - getpos() returns no entry if not found the key

As far as I read Andrew's message he is not against new semantics of
getpos(), which I still consider is good to have, but rather not to
forget update users accordingly.

Would it be worth doing like that?

-- 
With Best Regards,
Andy Shevchenko