linux-kernel - Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VetKS-nRcKGUd=+Jv+n3EOeSq0CSeY6yfx0rCBH4Y9=_Q@mail.gmail.com>
Date:   Thu, 18 May 2017 15:39:43 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sascha Weisenberger <sascha.weisenberger@...mens.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102

On Thu, May 18, 2017 at 3:31 PM, Jan Kiszka <jan.kiszka@...mens.com> wrote:
> On 2017-05-18 13:07, Andy Shevchenko wrote:
>> On Wed, May 17, 2017 at 6:28 PM, Jan Kiszka <jan.kiszka@...mens.com> wrote:
>>> This is an upstream port of an IIO driver for the TI ADC108S102 and
>>> ADC128S102. The former can be found on the Intel Galileo Gen2 and the
>>> Siemens SIMATIC IOT2000. For those boards, ACPI-based enumeration is
>>> included.
>>>
>>> Due to the lack of regulators under ACPI, we hard-code the voltage
>>> provided to the VA pin of the ADC to 5 V, the value used on Galileo and
>>> IOT2000. For DT usage, the regulator "vref-supply" provides this
>>> information. Note that DT usage has not been tested.
>>>
>>> Original author: Bogdan Pricop <bogdan.pricop@...tex.com>
>>> Ported from Intel Galileo Gen2 BSP to Intel Yocto kernel:
>>> Todor Minchev <todor@...chev.co.uk>.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
>>
>> It seems you missed my tag.
>>
>> FWIW:
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
>
> As the code changed again, I left it out. Thanks for confirming it that
> it still applies!

Yes, it does with the same remark about regulator API usage.

-- 
With Best Regards,
Andy Shevchenko