linux-kernel - Re: [PATCH] drm/i915: Check C for null pointer rather than B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170518135244.GF26693@nuc-i3427.alporthouse.com>
Date:   Thu, 18 May 2017 14:52:44 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Colin King <colin.king@...onical.com>
Cc:     Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        David Airlie <airlied@...ux.ie>,
        Mika Kuoppala <mika.kuoppala@...el.com>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: Check C for null pointer rather than B

On Thu, May 18, 2017 at 02:39:42PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There are two occasions where pointer B is being check for a NULL
> when it should be pointer C instead. Fix these.
> 
> Detected by CoverityScan, CID#1436348,1436349 ("Logically Dead Code")
> 
> Fixes: 47624cc3301b60 ("drm/i915: Import the kfence selftests for i915_sw_fence")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks, obviously correct and not exercised by BAT so pushed.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre