linux-kernel - Re: [PATCH] ovl: fix ovl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpeguo4rVL44Zwz8LAXwZt5k4cJ1ojfR5hjvg5hMEDto_2HA@mail.gmail.com>
Date:   Thu, 18 May 2017 16:13:50 +0200
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "open list:OVERLAY FILESYSTEM" <linux-unionfs@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ovl: fix ovl_rename error handling

On Thu, May 18, 2017 at 3:57 PM, Amir Goldstein <amir73il@...il.com> wrote:
> On Thu, May 18, 2017 at 4:34 PM, Arnd Bergmann <arnd@...db.de> wrote:
>> We try to clean up two objects before they got initialized:
>>
>> fs/overlayfs/dir.c: In function 'ovl_rename':
>> fs/overlayfs/dir.c:1060:2: error: 'newdentry' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>> fs/overlayfs/dir.c:891:17: note: 'newdentry' was declared here
>> fs/overlayfs/dir.c:1062:2: error: 'olddentry' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>> fs/overlayfs/dir.c:890:17: note: 'olddentry' was declared here
>>
>> Assuming that no special cleanup is required for the new code, the correct
>> branch target should be "out_revert_creds" to clean up everything that
>> got initialized up to then.
>>
>
> Yep, this is correct. You are the 4th to send this patch :)
> Thanks

Pushed to overlayfs-next together with other fixes.  Sorry for the delay.

Thanks,
Miklos