linux-kernel - Re: [PATCH] iommu/dma: fix function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 May 2017 15:18:48 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     Arnd Bergmann <arnd@...db.de>, Joerg Roedel <jroedel@...e.de>
Cc:     Magnus Damm <damm+renesas@...nsource.se>,
        Will Deacon <will.deacon@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/dma: fix function declaration

On 18/05/17 14:13, Arnd Bergmann wrote:
> Newly added code in the ipmmu-vmsa driver showed a small mistake
> in a header file that can't be included by itself without CONFIG_IOMMU_DMA
> enabled:
> 
> In file included from drivers/iommu/ipmmu-vmsa.c:13:0:
> include/linux/dma-iommu.h:105:94: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> This adds a forward declaration for 'struct device', similar to how
> we treat the other struct types in this case.

Oops, looks like this was latent from day one, thanks Arnd.

Acked-by: Robin Murphy <robin.murphy@....com>

> Fixes: 3ae47292024f ("iommu/ipmmu-vmsa: Add new IOMMU_DOMAIN_DMA ops")
> Fixes: 273df9635385 ("iommu/dma: Make PCI window reservation generic")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  include/linux/dma-iommu.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/dma-iommu.h b/include/linux/dma-iommu.h
> index 4eac2670bfa1..92f20832fd28 100644
> --- a/include/linux/dma-iommu.h
> +++ b/include/linux/dma-iommu.h
> @@ -78,6 +78,7 @@ void iommu_dma_get_resv_regions(struct device *dev, struct list_head *list);
>  
>  struct iommu_domain;
>  struct msi_msg;
> +struct device;
>  
>  static inline int iommu_dma_init(void)
>  {
>