linux-kernel - Re: [PATCH] crypto: hifn_795x: Fix a handful of minor bugs spotted by eye

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170518.000234.2271722938216696157.davem@davemloft.net>
Date:   Thu, 18 May 2017 00:02:34 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     logang@...tatee.com
Cc:     herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: hifn_795x: Fix a handful of minor bugs spotted
 by eye

From: Logan Gunthorpe <logang@...tatee.com>
Date: Wed, 17 May 2017 21:33:22 -0600

> 
> 
> On 17/05/17 09:26 PM, Herbert Xu wrote:
>> On Thu, May 18, 2017 at 11:25:06AM +0800, Herbert Xu wrote:
>>> On Fri, Apr 28, 2017 at 11:02:40AM -0600, Logan Gunthorpe wrote:
>>>> * Cleaned up the formatting of ablkcipher_get arguments so it complies
>>>>   with kernel style
>>>> * The offset in ablkcipher_get sould be added to the source, not the
>>>>   destination. We rename it to soffset for clarity.
>>>> * dst++ should be dst=sg_next(dst)
>>>> * We call kunmap_atomic earlier so we only have to do it once.
>>>> * If ablkcipher_get fails, we should probably ensure the request
>>>>   completes with an error.
> 
>>> Please don't mix unrelated changes in the same patch.
> 
> Seriously? The patch is tiny and those are all incredibly minor changes.

Yes, seriously.

It is the only way to make your changes easy to review and audit.

Please do as Herbert is asking.