linux-kernel - Re: [PATCH] Use ctlr directly in rdac_failover

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1495232608.2581.3.camel@sandisk.com>
Date:   Fri, 19 May 2017 22:23:30 +0000
From:   Bart Van Assche <Bart.VanAssche@...disk.com>
To:     "hare@...e.de" <hare@...e.de>,
        "asavkov@...hat.com" <asavkov@...hat.com>
CC:     "hch@....de" <hch@....de>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "axboe@...com" <axboe@...com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
Subject: Re: [PATCH] Use ctlr directly in rdac_failover_get()

On Fri, 2017-05-19 at 14:06 +0200, Artem Savkov wrote:
> rdac_failover_get references struct rdac_controller as
> ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being
> inefficient this also introduces a null-pointer dereference as
> send_mode_select() sets ctlr->ms_sdev to NULL before calling
> rdac_failover_get():
> 
> [ ... ]
> Signed-off-by: Artem Savkov <asavkov@...hat.com>

Hello Artem,

Although this patch looks fine to me, please consider adding the "Fixes:" and
"Cc: <stable@...r.kernel.org>" tags.

Bart.