linux-kernel - Re: [PATCH v2] scsi: zero per-cmd private driver data for each MQ I/O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq18tlt4o23.fsf@oracle.com>
Date:   Thu, 18 May 2017 21:45:24 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Long Li <longli@...hange.microsoft.com>
Cc:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        KY Srinivasan <kys@...rosoft.com>,
        Bart Van Assche <Bart.VanAssche@...disk.com>,
        Christoph Hellwig <hch@...radead.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Long Li <longli@...rosoft.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2] scsi: zero per-cmd private driver data for each MQ I/O


Long,

> In lower layer driver's (LLD) scsi_host_template, the driver may
> optionally ask SCSI to allocate its private driver memory for each
> command, by specifying cmd_size. This memory is allocated at the end
> of scsi_cmnd by SCSI.  Later when SCSI queues a command, the LLD can
> use scsi_cmd_priv to get to its private data.
>  
> Some LLD, e.g. hv_storvsc, doesn't clear its private data before
> use. In this case, the LLD may get to stale or uninitialized data in
> its private driver memory. This may result in unexpected driver and
> hardware behavior.
>
> Fix this problem by also zeroing the private driver memory before
> passing them to LLD.

Applied to 4.12/scsi-fixes. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering