linux-kernel - Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd265f3e-4beb-ef91-9b48-05c409c85fc4@gmail.com>
Date:   Fri, 19 May 2017 13:06:04 +0530
From:   suri <surenderpolsani@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, gregor.boirie@...rot.com,
        singhalsimran0@...il.com, maitysanchayan@...il.com,
        eraretuya@...il.com, linux-iio@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as
 per coding style

On Friday 19 May 2017 12:45 PM, Greg KH wrote:
> On Fri, May 19, 2017 at 12:33:11PM +0530, surenderpolsani@...il.com wrote:
>> From: Surender Polsani <surenderpolsani@...il.com>
>>
>> Fixed the following checkpatch.pl warnings:
>> octal permissions are more preferable than symbolic permissions
>>
>> Replaced DEVICE_ATTR family macros with DEVICE_ATTR_RW family
>> as suggested by Greg K-H. Changed attributes and function
>> names where ever required to satisfy internal macro definitions
>> like __ATTR__RW().
>
> No you did not:
>
>> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
>> +static DEVICE_ATTR(power_state, 0644,
>>  		tsl2x7x_power_state_show, tsl2x7x_power_state_store);
>
> ???
>
> Wrong patch?
>

Sorry i sent wrong patch by mistake. I will send correct patch shortly.