linux-kernel - Re: [PATCH] usb: chipidea: debug: check before accessing ci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170519005718.GA7460@b29397-desktop>
Date:   Fri, 19 May 2017 08:57:18 +0800
From:   Peter Chen <hzpeterchen@...il.com>
To:     Michael Thalmeier <michael.thalmeier@...e.at>
CC:     Peter Chen <Peter.Chen@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <michael@...lmeier.at>
Subject: Re: [PATCH] usb: chipidea: debug: check before accessing ci_role

On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote:
> ci_role BUGs when the role is >= CI_ROLE_END.
> 
> Signed-off-by: Michael Thalmeier <michael.thalmeier@...e.at>
> ---
>  drivers/usb/chipidea/debug.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
> index 6d23eed..1c31e8a 100644
> --- a/drivers/usb/chipidea/debug.c
> +++ b/drivers/usb/chipidea/debug.c
> @@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data)
>  {
>  	struct ci_hdrc *ci = s->private;
>  
> -	seq_printf(s, "%s\n", ci_role(ci)->name);
> +	if (ci->role != CI_ROLE_END)
> +		seq_printf(s, "%s\n", ci_role(ci)->name);
>  
>  	return 0;
>  }

I will queue it, and cc stable

-- 

Best Regards,
Peter Chen