linux-kernel - Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 May 2017 10:20:41 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     surenderpolsani@...il.com
Cc:     jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, gregor.boirie@...rot.com,
        devel@...verdev.osuosl.org, eraretuya@...il.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        maitysanchayan@...il.com, singhalsimran0@...il.com
Subject: Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as
 per coding style

On Fri, May 19, 2017 at 01:42:55PM +0530, surenderpolsani@...il.com wrote:
> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
> -		tsl2x7x_power_state_show, tsl2x7x_power_state_store);
> +static DEVICE_ATTR_RW(tsl2x7x_power_state);

You do realize you just renamed the sysfs file, changing the user/kernel
api?  That's generally not a good thing to ever do :(

thanks,

greg k-h