linux-kernel - Re: [PATCH v2 8/9] crypto: mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 May 2017 11:11:06 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        thomas.lendacky@....com, gary.hook@....com,
        boris.brezillon@...e-electrons.com, arno@...isbad.org,
        giovanni.cabiddu@...el.com, salvatore.benedetto@...el.com
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, qat-linux@...el.com
Subject: Re: [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant



On 19/05/17 08:53, Corentin Labbe wrote:
> This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
> define.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ---

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

>   drivers/crypto/mediatek/mtk-sha.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/mediatek/mtk-sha.c b/drivers/crypto/mediatek/mtk-sha.c
> index 2226f12d1c7a..5f4f845adbb8 100644
> --- a/drivers/crypto/mediatek/mtk-sha.c
> +++ b/drivers/crypto/mediatek/mtk-sha.c
> @@ -12,6 +12,7 @@
>    * Some ideas are from atmel-sha.c and omap-sham.c drivers.
>    */
>   
> +#include <crypto/hmac.h>
>   #include <crypto/sha.h>
>   #include "mtk-platform.h"
>   
> @@ -825,8 +826,8 @@ static int mtk_sha_setkey(struct crypto_ahash *tfm, const u8 *key,
>   	memcpy(bctx->opad, bctx->ipad, bs);
>   
>   	for (i = 0; i < bs; i++) {
> -		bctx->ipad[i] ^= 0x36;
> -		bctx->opad[i] ^= 0x5c;
> +		bctx->ipad[i] ^= HMAC_IPAD_VALUE;
> +		bctx->opad[i] ^= HMAC_OPAD_VALUE;
>   	}
>   
>   	return 0;
>