linux-kernel - Re: [PATCH] kbuild: simplify silent build (-s) detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f1d9a57-5447-c23a-156a-02e7cab2d29a@suse.com>
Date:   Fri, 19 May 2017 12:53:25 +0200
From:   Michal Marek <mmarek@...e.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kbuild@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: simplify silent build (-s) detection

On 2017-05-19 06:28, Masahiro Yamada wrote:
> This allows to detect -s option without checking GNU Make version.
> 
> As commit e36aaea28972 ("kbuild: Fix silent builds with make-4")
> pointed out, GNU Make 4.x changed the way/order it presents the
> command line options into MAKEFLAGS.
> 
> In Make 3.8x, 's' is always be the first in a group of short options.
> The group could be prefixed with '-'.
> 
> In Make 4.x, 's' is always the last in a group of short options.
> 
> As commit e6ac89fabd03 ("kbuild: Correctly deal with make options
> which contain an 's'") addressed, we also need to deal with long
> options that end with 's', like --warn-undefined-variables.
> 
> Test cases:
> 
> [1] command line input:    make --silent
>      -> MAKEFLAGS for Make 3.8x:    s
>      -> MAKEFLAGS for Make 4.x :    s
> 
> [2] command line input:    make -srR
>      -> MAKEFLAGS for Make 3.8x:    sRr
>      -> MAKEFLAGS for Make 4.x :    rRs
> 
> [3] command line input:    make -s -rR --warn-undefined-variables
>      -> MAKEFLAGS for Make 3.8x:    --warn-undefined-variables -sRr
>      -> MAKEFLAGS for Make 4.x :    rRs --warn-undefined-variables
> 
> We can take care of them, by filtering out long options (--%),
> then matching -s% s% %s patterns.

Good idea, that's a much cleaner way.

Michal