linux-kernel - Re: [PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1495193335.627.66.camel@redhat.com>
Date:   Fri, 19 May 2017 13:28:55 +0200
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     Xiaoguang Chen <xiaoguang.chen@...el.com>
Cc:     alex.williamson@...hat.com, intel-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, zhenyuw@...ux.intel.com,
        zhiyuan.lv@...el.com, intel-gvt-dev@...ts.freedesktop.org,
        zhi.a.wang@...el.com, kevin.tian@...el.com
Subject: Re: [PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g

> +/**
> + * Ioctl to query plane info or create dma-buf
> + */
> +#define INTEL_VGPU_QUERY_DMABUF		0
> +#define INTEL_VGPU_GENERATE_DMABUF	1

This should use _IO* #defines.

> +struct intel_vgpu_dmabuf {
> +	__u32 plane_id;
> +	/* out */
> +	__u32 fd;
> +	__u32 drm_format;
> +	__u32 width;
> +	__u32 height;
> +	__u32 stride;
> +	__u32 start;
> +	__u32 x_pos;
> +	__u32 y_pos;
> +	__u32 size;
> +	__u32 tiled;

I'd suggest to drop tiled, and add drm_format_mod (for
fourcc_mod_code()) instead.

You can also move intel_vgpu_plane_info to this place and just use it as
sub-struct for intel_vgpu_dmabuf.

cheers,
  Gerd