linux-kernel - Re: [PATCH] efi-pstore: Fix read iter after pstore API refactor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKv+Gu-5-L98S6KJcGsdiQxM_ZePja1dcaVdaQsfNzGJDLxy2g@mail.gmail.com>
Date:   Fri, 19 May 2017 14:30:37 +0100
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        Seiji Aguchi <seiji.aguchi@....com>,
        Geliang Tang <geliangtang@....com>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>
Subject: Re: [PATCH] efi-pstore: Fix read iter after pstore API refactor

On 18 May 2017 at 17:41, Kees Cook <keescook@...omium.org> wrote:
> On Thu, May 18, 2017 at 9:18 AM, Ard Biesheuvel
> <ard.biesheuvel@...aro.org> wrote:
>> On 18 May 2017 at 14:01, Kees Cook <keescook@...omium.org> wrote:
>>> On Thu, May 18, 2017 at 3:35 AM, Ard Biesheuvel
>>> <ard.biesheuvel@...aro.org> wrote:
>>>> On 12 May 2017 at 22:58, Kees Cook <keescook@...omium.org> wrote:
>>>>> During the internal pstore API refactoring, the EFI vars read entry was
>>>>> accidentally made to update a stack variable instead of the pstore
>>>>> private data pointer. This corrects the problem (and removes the now
>>>>> needless argument).
>>>>>
>>>>> Signed-off-by: Kees Cook <keescook@...omium.org>
>>>>
>>>> Does this need a cc stable?
>>>
>>> No, the refactor first appeared in 4.12-rc1.
>>>
>>
>> OK. Applied.
>
> Err, eek, no, it's already gone into Linus's tree.
>

OK, I dropped it again :-)