linux-kernel - Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170519141522.GA1830@lst.de>
Date:   Fri, 19 May 2017 16:15:22 +0200
From:   Christoph Hellwig <hch@....de>
To:     Keith Busch <keith.busch@...el.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Jens Axboe <axboe@...nel.dk>, Sagi Grimberg <sagi@...mberg.me>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-nvme <linux-nvme@...ts.infradead.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Mario Limonciello <mario_limonciello@...l.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] nvme: Change our APST table to be no more aggressive
        than Intel RSTe

On Fri, May 19, 2017 at 10:18:34AM -0400, Keith Busch wrote:
> +
> +	if (ns->ctrl->quirks & NVME_QUIRK_PAGE_ALIGN)
> +		blk_queue_logical_block_size(ns->queue, ns->ctrl->page_size);
> +	else
> +		blk_queue_logical_block_size(ns->queue, bs);

Ugg.  That will invalidate the layout of any existing fs (in case the
device hasn't eaten it yet).  It would also invalidate things like
partitions tables, even if they are only used to share with windows.