[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170519082122.7f56aa38@xeon-e3>
Date: Fri, 19 May 2017 08:21:22 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: Jork Loeser <jloeser@...rosoft.com>, olaf@...fle.de,
sthemmin@...rosoft.com, linux-pci@...r.kernel.org,
jasowang@...hat.com, linux-kernel@...r.kernel.org,
marcelo.cerri@...onical.com, helgaas@...nel.org, apw@...onical.com,
devel@...uxdriverproject.org, vkuznets@...hat.com,
leann.ogasawara@...onical.com
Subject: Re: [PATCH 4/4] Hyper-V vPCI: use vPCI protocol version 1.2
On Fri, 19 May 2017 14:27:01 +0300
Dan Carpenter <dan.carpenter@...cle.com> wrote:
> > /*
> > + * HV_VP_SET available
> > + */
> > +#define HV_X64_EX_PROCESSOR_MASKS_RECOMMENDED (1 << 11)
>
> Use BIT(11). I thought checkpatch.pl complains about this but I guess
> that's only with the --strict option.
Since all the other field values are encoded as shifts, doing something
different for this field stands out. Therefore just use (1 << 11)
or change all the previous values using BIT() macro
Powered by blists - more mailing lists