linux-kernel - Re: [PATCH v5 01/11] mm: x86: move _PAGE_SWP_SOFT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea4597a9-d5a3-4f66-af44-b99f396acf66@intel.com>
Date:   Fri, 19 May 2017 09:36:22 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Zi Yan <zi.yan@...rutgers.edu>
Cc:     n-horiguchi@...jp.nec.com, kirill.shutemov@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, minchan@...nel.org, vbabka@...e.cz,
        mgorman@...hsingularity.net, mhocko@...nel.org,
        khandual@...ux.vnet.ibm.com, dnellans@...dia.com
Subject: Re: [PATCH v5 01/11] mm: x86: move _PAGE_SWP_SOFT_DIRTY from bit 7 to
 bit 1

On 05/19/2017 09:31 AM, Zi Yan wrote:
>> This description lacks a problem statement.  What's the problem?
>>
>> 	_PAGE_PSE is used to distinguish between a truly non-present
>> 	(_PAGE_PRESENT=0) PMD, and a PMD which is undergoing a THP
>> 	split and should be treated as present.
>>
>> 	But _PAGE_SWP_SOFT_DIRTY currently uses the _PAGE_PSE bit,
>> 	which would cause confusion between one of those PMDs
>> 	undergoing a THP split, and a soft-dirty PMD.
>>
>> 	Thus, we need to move the bit.
>>
>> Does that capture it?
> Yes. I will add this in the next version.

OK, thanks for clarifying.  You can add my acked-by on this.

But, generally, these bits really scare me.  We don't have any nice
programmatic way to find conflicts.  I really wish we had some
BUILD_BUG_ON()s or something to express these dependencies.