linux-kernel - Re: [PATCH] regmap: add regmap_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170519164616.a4c3ojkfid6oqnts@sirena.org.uk>
Date:   Fri, 19 May 2017 17:46:16 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Stefan Agner <stefan@...er.ch>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: add regmap_debugfs_exit as devres action

On Mon, May 15, 2017 at 01:08:27AM -0700, Stefan Agner wrote:

> Instead of manually cleanup regmap_debugfs_exit, use devres action
> to do the cleanup. This also works for external users of
> regmap_attach_dev.

Why?  It's also not clear to me that this will work if something creates
a regmap, frees it and then creates another one on the same device
without a reprobe.  There have been a few devices that did that as part
of enumeration of the device, they created a simple regmap to read ID
registers then replaced it with a more complete description of the
actual device they found.

> This fixes warnings when reloading certain drivers making use of
> regmap_debugfs_exit:
>   imx7d-pinctrl 30330000.iomuxc: Failed to create debugfs directory

How?  (and this should be in the changelog.)

> @@ -1215,7 +1216,6 @@ void regmap_exit(struct regmap *map)
>  	struct regmap_async *async;
>  
>  	regcache_exit(map);
> -	regmap_debugfs_exit(map);
>  	regmap_range_exit(map);
>  	if (map->bus && map->bus->free_context)
>  		map->bus->free_context(map->bus_context);

This isn't obviously correct, it reorders the cleanup such that the
debugfs entries will only get removed when the device is removed which
means that the debugfs entries will be hanging around after the regmap
has been deinstantiated.  In the common case where it too was allocated
as a managed resource that'll work out but if for some reason it wasn't
allocated as as managed resource then the debugfs entry will be
dealocated after the regmap.

We should also be doing the debugfs cleanup before the regcache cleanup
but that's a separate and preexisting bug.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)