linux-kernel - NACK: [PATCH] [media] rainshadow-cec: ensure exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 May 2017 18:43:15 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Arnd Bergmann <arnd@...db.de>, Eric Anholt <eric@...olt.net>,
        David Airlie <airlied@...ux.ie>,
        Hans Verkuil <hverkuil@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: NACK: [PATCH] [media] rainshadow-cec: ensure exit_loop is initialized

On 19/05/17 18:39, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> exit_loop is not being initialized, so it contains garbage. Ensure it is
> initialized to false.
> 
> Detected by CoverityScan, CID#1436409 ("Uninitialzed scalar variable")
> 
> Fixes: ea6a69defd3311 ("[media] rainshadow-cec: avoid -Wmaybe-uninitialized warning")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/gpu/drm/vc4/vc4_v3d.c                     | 2 +-
>  drivers/media/usb/rainshadow-cec/rainshadow-cec.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c
> index c53afec34586..c42210203f6e 100644
> --- a/drivers/gpu/drm/vc4/vc4_v3d.c
> +++ b/drivers/gpu/drm/vc4/vc4_v3d.c
> @@ -218,7 +218,7 @@ int vc4_v3d_get_bin_slot(struct vc4_dev *vc4)
>   * overall CMA pool before they make scenes complicated enough to run
>   * out of bin space.
>   */
> -int
> +static int
>  vc4_allocate_bin_bo(struct drm_device *drm)
>  {
>  	struct vc4_dev *vc4 = to_vc4_dev(drm);
> diff --git a/drivers/media/usb/rainshadow-cec/rainshadow-cec.c b/drivers/media/usb/rainshadow-cec/rainshadow-cec.c
> index 8d3ca2c8b20f..ad468efc4399 100644
> --- a/drivers/media/usb/rainshadow-cec/rainshadow-cec.c
> +++ b/drivers/media/usb/rainshadow-cec/rainshadow-cec.c
> @@ -119,7 +119,7 @@ static void rain_irq_work_handler(struct work_struct *work)
>  
>  	while (true) {
>  		unsigned long flags;
> -		bool exit_loop;
> +		bool exit_loop = false;
>  		char data;
>  
>  		spin_lock_irqsave(&rain->buf_lock, flags);
> 
Sorry, got another fix included into that. I'll re-submit