linux-kernel - [PATCH v2] zlib: Mark get_unaligned16() as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170519181016.17921-1-mka@chromium.org>
Date:   Fri, 19 May 2017 11:10:16 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Matthias Kaehlcke <mka@...omium.org>
Subject: [PATCH v2] zlib: Mark get_unaligned16() as __maybe_unused

The function is not used with all configurations. Adding the attribute
fixes the following warning when building with clang and
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y:

lib/zlib_inflate/inffast.c:31:1: error: unused function 'get_unaligned16'
    [-Werror,-Wunused-function]
get_unaligned16(const unsigned short *p)

Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
---
Changes in v2:
- explicitly include <linux/compiler.h> where __maybe_unused is defined

 lib/zlib_inflate/inffast.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/zlib_inflate/inffast.c b/lib/zlib_inflate/inffast.c
index 2c13ecc5bb2c..bae26afdc565 100644
--- a/lib/zlib_inflate/inffast.c
+++ b/lib/zlib_inflate/inffast.c
@@ -3,6 +3,7 @@
  * For conditions of distribution and use, see copyright notice in zlib.h
  */
 
+#include <linux/compiler.h>
 #include <linux/zutil.h>
 #include "inftrees.h"
 #include "inflate.h"
@@ -27,7 +28,7 @@ union uu {
 };
 
 /* Endian independed version */
-static inline unsigned short
+static inline unsigned short __maybe_unused
 get_unaligned16(const unsigned short *p)
 {
 	union uu  mm;
-- 
2.13.0.303.g4ebf302169-goog