linux-kernel - Re: [PATCH v5 02/11] mm: mempolicy: add queue_pages_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61FCE04A-0227-4D5E-92E5-81EA06979FD3@cs.rutgers.edu>
Date:   Fri, 19 May 2017 16:48:54 -0400
From:   "Zi Yan" <zi.yan@...rutgers.edu>
To:     "Mel Gorman" <mgorman@...hsingularity.net>
Cc:     "Anshuman Khandual" <khandual@...ux.vnet.ibm.com>,
        n-horiguchi@...jp.nec.com, kirill.shutemov@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, minchan@...nel.org, vbabka@...e.cz,
        mhocko@...nel.org, dnellans@...dia.com
Subject: Re: [PATCH v5 02/11] mm: mempolicy: add queue_pages_node_check()

On 19 May 2017, at 16:28, Mel Gorman wrote:

> On Fri, May 19, 2017 at 12:37:38PM -0400, Zi Yan wrote:
>>> As you say, there is no functional change but the helper name is vague
>>> and gives no hint to what's it's checking for. It's somewhat tolerable as
>>> it is as it's obvious what is being checked but the same is not true with
>>> the helper name.
>>>
>>
>> Does queue_pages_invert_nodemask_check() work? I can change the helper name
>> in the next version.
>>
>
> Not particularly, maybe queue_pages_required and invert the check with a
> comment above it explaining what it's checking for would be ok.
>

queue_pages_required() is too broad, I would take queue_pages_page_nid_check()
and invert the check with a comment above saying

/*
 * Check if the page's nid is in qp->nmask.
 *
 * If MPOL_MF_INVERT is set in qp->flags, check if the nid is
 * in the invert of qp->nmask.
 */

Does it work?

--
Best Regards
Yan Zi

Download attachment "signature.asc" of type "application/pgp-signature" (497 bytes)