linux-kernel - Re: [PATCH] iio: light: isl29018: Only declare ACPI table when ACPI is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1102f6ab-e457-f0cb-4b71-7f855383949e@kernel.org>
Date:   Sat, 20 May 2017 17:08:49 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Guenter Roeck <groeck@...gle.com>,
        Matthias Kaehlcke <mka@...omium.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Brian Masney <masneyb@...tation.org>,
        linux-iio@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH] iio: light: isl29018: Only declare ACPI table when ACPI
 is enabled

On 19/05/17 22:57, Guenter Roeck wrote:
> On Fri, May 19, 2017 at 2:28 PM, Matthias Kaehlcke <mka@...omium.org> wrote:
>> This fixes the following warning when building with clang:
>>
>> drivers/iio/light/isl29018.c:808:36: error: variable
>>      'isl29018_acpi_match' is not needed and will not be emitted
>>      [-Werror,-Wunneeded-internal-declaration]
>>
>> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> 
> Reviewed-by: Guenter Roeck <groeck@...omium.org>
I wondered if we would be slightly neater if we went with
__maybe_unused markings but realised I didn't really care enough
to make you respin the patch ;)  So if anyone else has strong
feelings on the two options, shout out now.

Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan
> 
>> ---
>>   drivers/iio/light/isl29018.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/iio/light/isl29018.c b/drivers/iio/light/isl29018.c
>> index 917dd8b43e72..61f5924b472d 100644
>> --- a/drivers/iio/light/isl29018.c
>> +++ b/drivers/iio/light/isl29018.c
>> @@ -807,6 +807,7 @@ static SIMPLE_DEV_PM_OPS(isl29018_pm_ops, isl29018_suspend, isl29018_resume);
>>   #define ISL29018_PM_OPS NULL
>>   #endif
>>
>> +#ifdef CONFIG_ACPI
>>   static const struct acpi_device_id isl29018_acpi_match[] = {
>>          {"ISL29018", isl29018},
>>          {"ISL29023", isl29023},
>> @@ -814,6 +815,7 @@ static const struct acpi_device_id isl29018_acpi_match[] = {
>>          {},
>>   };
>>   MODULE_DEVICE_TABLE(acpi, isl29018_acpi_match);
>> +#endif
>>
>>   static const struct i2c_device_id isl29018_id[] = {
>>          {"isl29018", isl29018},
>> --
>> 2.13.0.303.g4ebf302169-goog
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>