linux-kernel - [PATCH RFC] perf/callchain: fixup charset file header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 20 May 2017 18:47:31 +0200
From:   Nicholas Mc Guire <der.herr@...r.at>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Markus Kreidl <mkreidl@...ntech.at>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Paul Mackerras <paulus@....ibm.com>,
        linux-kernel@...r.kernel.org, Nicholas Mc Guire <der.herr@...r.at>
Subject: [PATCH RFC] perf/callchain: fixup charset file header

Non-UTF-8 characters are a problem for some terminals and also
make greping harder than necessary - this only switches the
copyright sign to the common (C).

Reported-by: Markus Kreidl <mkreidl@...ntech.at>
Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>
---

Found by checkpatch --strict:
CHECK: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#7: FILE: kernel/events/callchain.c:7:
+ *  Copyright  ©  2009 Paul Mackerras, IBM Corp. <paulus@....ibm.com>

Before I start generating sets of patches that fix encoding issues 
I would like to know if that is going to be accepted at all - the
background is that it causes quite a bit of trouble when automating
tools if these encoding problems make using simple tools hard (e.g.
grep) and thus make automation a lot more complicated that necessary.
It seems to me that the codingstyle does not mandate UTF-8 but there
are a few places where it is "suggested" like in:
  Documentation/process/email-clients.rst

This really should not have any impact on the code but 
patch was compile-tested with x86_64_defconfig (implies CONFIG_PERF_EVENTS)
(issues two sparse warnings - not related though)

Patch is against 4.12-rc1 (localversion-next is next-20170519)

 kernel/events/callchain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c
index 1b2be63..357f488 100644
--- a/kernel/events/callchain.c
+++ b/kernel/events/callchain.c
@@ -4,7 +4,7 @@
  *  Copyright (C) 2008 Thomas Gleixner <tglx@...utronix.de>
  *  Copyright (C) 2008-2011 Red Hat, Inc., Ingo Molnar
  *  Copyright (C) 2008-2011 Red Hat, Inc., Peter Zijlstra
- *  Copyright  ©  2009 Paul Mackerras, IBM Corp. <paulus@....ibm.com>
+ *  Copyright (C) 2009 Paul Mackerras, IBM Corp. <paulus@....ibm.com>
  *
  * For licensing details see kernel-base/COPYING
  */
-- 
2.1.4