linux-kernel - Re: [PATCH] Make x86 use $TARGET-readelf like all the other arches.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJZeE91t+dYNgD3GnqyL-eva0uhKnOtNhrGyL2KZLQY1Q@mail.gmail.com>
Date:   Sat, 20 May 2017 16:46:20 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Rob Landley <rob@...dley.net>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "x86@...nel.org" <x86@...nel.org>, Jiri Kosina <jkosina@...e.cz>,
        Paul Bolle <pebolle@...cali.nl>,
        "H.J. Lu" <hjl.tools@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Make x86 use $TARGET-readelf like all the other arches.

On Sat, May 20, 2017 at 1:03 PM, Rob Landley <rob@...dley.net> wrote:
> From: Rob Landley <rob@...dley.net>
>
> My cross-compile environment doesn't provide an unprefixed
> readelf in the $PATH, which works fine on every target but x86,
> where you get a bunch of "/bin/sh: 1: readelf: not found"
> messages (but the result still works anyway).
>
> Signed-off-by: Rob Landley <rob@...dley.net>

Ooops, thanks for the catch!

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>
>  arch/x86/boot/compressed/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> index 44163e8..2c860ad 100644
> --- a/arch/x86/boot/compressed/Makefile
> +++ b/arch/x86/boot/compressed/Makefile
> @@ -94,7 +94,7 @@ vmlinux-objs-$(CONFIG_EFI_MIXED) += $(obj)/efi_thunk_$(BITS).o
>  quiet_cmd_check_data_rel = DATAREL $@
>  define cmd_check_data_rel
>         for obj in $(filter %.o,$^); do \
> -               readelf -S $$obj | grep -qF .rel.local && { \
> +               ${CROSS_COMPILE}readelf -S $$obj | grep -qF .rel.local && { \
>                         echo "error: $$obj has data relocations!" >&2; \
>                         exit 1; \
>                 } || true; \



-- 
Kees Cook
Pixel Security