linux-kernel - Re: [GIT PULL] KVM fixes for v4.12-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 20 May 2017 12:52:05 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Radim Krčmář <rkrcmar@...hat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] KVM fixes for v4.12-rc2

On 20/05/17 00:21, Linus Torvalds wrote:
> So I noticed that my diffstat didn't match either the KVM or the Xen pull.
> 
> The *reason* seems to be that both Radim and Juergen have enabled the
> "patience" diff, because if I add "--patience" to the diff line, I get
> the same numbers you guys report.
> 
> On Fri, May 19, 2017 at 11:43 AM, Radim Krčmář <rkrcmar@...hat.com> wrote:
>>
>>  28 files changed, 297 insertions(+), 125 deletions(-)
> 
> Without "--patience" (the default) I get:
> 
>  28 files changed, 292 insertions(+), 120 deletions(-)
> 
> which is close, but not the exact same thing.
> 
> So I don't mind people using the patience version of the diffing code,
> but on the whole it's a loss as often as it is a win, so I'm wondering
> _why_ you do this? Is there some other project that has started
> suggesting using the patience diff (either with a command line option
> or by just doing
> 
>   git config diff.algorithm patience
> 
> anyway, it's not a big deal, I'm just curious..

In my case it was a patch which was much easier to review using the
patience diff. I just didn't switch back afterwards (what I did now).


Juergen