linux-kernel - Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51a14f4e-8771-3bca-b05f-25732da50b34@vodafone.de>
Date:   Sat, 20 May 2017 13:39:42 +0200
From:   Christian König <deathsimple@...afone.de>
To:     Lyude <lyude@...hat.com>, amd-gfx@...ts.freedesktop.org
Cc:     David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

Am 20.05.2017 um 01:48 schrieb Lyude:
> This is the first part of me going through and cleaning up the IRQ handling
> code for radeon, since after taking a look at it the other day while trying to
> debug something I realized basically all of the code was copy pasted
> everywhere, and quite difficult to actually read through.
>
> Will come up with something for r600 and cik once I've got the chipsets on hand
> to test with.
>
> Lyude (3):
>    drm/radeon: Cleanup display interrupt handling for evergreen, si
>    drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
>    drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si

I don't have time to do a line by line review, but what I saw looked 
very good to me.

So the whole seres is Acked-by: Christian König <christian.koenig@....com>.

BTW: You don't want to take a look at the other hw generations as well?

Regards,
Christian.

>
>   drivers/gpu/drm/radeon/evergreen.c      | 943 ++++++--------------------------
>   drivers/gpu/drm/radeon/radeon.h         |  27 +-
>   drivers/gpu/drm/radeon/radeon_irq_kms.c |  35 ++
>   drivers/gpu/drm/radeon/si.c             | 655 +++++-----------------
>   4 files changed, 344 insertions(+), 1316 deletions(-)
>