linux-kernel - Re: [PATCH V3] acpi: apei: check for pending errors when probing GHES entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170521133910.GA5676@nazgul.tnic>
Date:   Sun, 21 May 2017 15:39:10 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Tyler Baicar <tbaicar@...eaurora.org>
Cc:     rjw@...ysocki.net, lenb@...nel.org, prarit@...hat.com,
        bhelgaas@...gle.com, punit.agrawal@....com, mingo@...nel.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        shiju.jose@...wei.com, James.Morse@....com, ahs3@...hat.com
Subject: Re: [PATCH V3] acpi: apei: check for pending errors when probing
 GHES entries

On Thu, May 18, 2017 at 03:22:42PM -0600, Tyler Baicar wrote:
> Check for pending errors when probing GHES entries. It is possible
> that a fatal error is already pending at this point, so we should
> handle it as soon as the driver is probed. This also avoids a
> potential issue if there was an interrupt that was already
> cleared for an error since the GHES driver wasn't present.
> 
> V3: Check for pending errors of all GHES types
> 
> Signed-off-by: Tyler Baicar <tbaicar@...eaurora.org>
> ---
>  drivers/acpi/apei/ghes.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d0855c0..5347230 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1039,6 +1039,9 @@ static int ghes_probe(struct platform_device *ghes_dev)
>  	}
>  	platform_set_drvdata(ghes_dev, ghes);
>  
> +	/* Handle any pending errors right away */
> +	ghes_proc(ghes);
> +
>  	return 0;
>  err_edac_unreg:
>  	ghes_edac_unregister(ghes);

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--