linux-kernel - RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EE11001F9E5DDD47B7634E2F8A612F2E40A45545@FRAEML521-MBX.china.huawei.com>
Date:   Sun, 21 May 2017 15:00:46 +0000
From:   Gabriele Paoloni <gabriele.paoloni@...wei.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "helgaas@...nel.org" <helgaas@...nel.org>,
        Linuxarm <linuxarm@...wei.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "lukas@...ner.de" <lukas@...ner.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "liudongdong (C)" <liudongdong3@...wei.com>
Subject: RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI
 interrupts for PCIe port services

Hi Christoph

> -----Original Message-----
> From: linux-pci-owner@...r.kernel.org [mailto:linux-pci-
> owner@...r.kernel.org] On Behalf Of Christoph Hellwig
> Sent: 21 May 2017 09:33
> To: Gabriele Paoloni
> Cc: bhelgaas@...gle.com; helgaas@...nel.org; Linuxarm; linux-
> pci@...r.kernel.org; lukas@...ner.de; linux-kernel@...r.kernel.org;
> mika.westerberg@...ux.intel.com; hch@...radead.org; liudongdong (C)
> Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI
> interrupts for PCIe port services
> 
> > +		 *
> > +		 * pci_irq_vector() below is able to handle entry
> diff erently
> > +		 * depending on MSI vs MSI-x case
> > +		 *
> >  		 */
> 
> One more instance of this comment left :)

I thought that in your previous review you meant to say that we should
avoid 2 instances of the same comment (in this patchset I only have this 
instance as I have removed the same comment from patch 2/2...)

> 
> >  		pcie_capability_read_word(dev, PCI_EXP_FLAGS, &reg16);
> >  		entry = (reg16 & PCI_EXP_FLAGS_IRQ) >> 9;
> > @@ -100,7 +107,10 @@ static int pcie_port_enable_msix(struct pci_dev
> *dev, int *irqs, int mask)
> >  		 * MSI/MSI-X vectors assigned to the port is going to be
> used
> >  		 * for AER, where "For MSI-X, the value in this register
> >  		 * indicates which MSI-X Table entry is used to generate
> the
> > -		 * interrupt message."
> > +		 * interrupt message."  and "For MSI, the value
> > +		 * in this field indicates the offset between the base
> Message
> > +		 * Data and the interrupt message that is generated."
> > +		 *
> >  		 */
> 
> And while this is getting a little too deep into nitpicking:  we
> usually
> don't add empty lines to the end of comments.

Ok I can remove the extra line and send out patch v4...

Many thanks
Gab