[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1495327414.2093.8.camel@perches.com>
Date: Sat, 20 May 2017 17:43:34 -0700
From: Joe Perches <joe@...ches.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: James Smart <james.smart@...adcom.com>,
Dick Kennedy <dick.kennedy@...adcom.com>,
"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Hannes Reinecke <hare@...e.com>,
Johannes Thumshirn <jthumshirn@...e.de>,
linux-scsi@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lpfc: nvmet_fc: fix format string
On Sat, 2017-05-20 at 21:10 +0200, Arnd Bergmann wrote:
> On Sat, May 20, 2017 at 12:28 PM, Joe Perches <joe@...ches.com> wrote:
> > On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote:
> > > The lpfc_nvmeio_data() tracing helper always takes a format string and
> > > three additional arguments.
> >
> > No it doesn't. It takes a format and arguments.
> >
> > I don't disagree with the patch, just the characterization
> > of the lpfc_mvmeio_data call in the commit message.
>
> I think my description is correct, it's just not obvious from
> reading the code until you also look at the lpfc_debugfs_nvme_trc
> prototype:
OK, but more that's a mismatch between a function and its
arguments and a different called function within it.
Powered by blists - more mailing lists