linux-kernel - Re: [PATCH -next] drm/pl111: Fix return value check in pl111_amba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k2587d9d.fsf@eliezer.anholt.net>
Date:   Mon, 22 May 2017 15:11:42 -0700
From:   Eric Anholt <eric@...olt.net>
To:     Wei Yongjun <weiyj.lk@...il.com>, David Airlie <airlied@...ux.ie>,
        Tom Cooksey <tom.cooksey@....com>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/pl111: Fix return value check in pl111_amba_probe()

Wei Yongjun <weiyj.lk@...il.com> writes:

> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed and applied.  Thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)