linux-kernel - Re: [PATCH 3/3] gpio: adp5588: move header file out of I2C realm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170522234026.GD12016@dtor-ws>
Date:   Mon, 22 May 2017 16:40:26 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     linux-i2c@...r.kernel.org, Steven Miao <realmz6@...il.com>,
        Michael Hennerich <michael.hennerich@...log.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        adi-buildroot-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 3/3] gpio: adp5588: move header file out of I2C realm

On Sun, May 21, 2017 at 11:57:27PM +0200, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
> 
> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
> ---
> 
> This driver could also go via the input-tree or my tree. I don't really care
> and just picked some subsystem :) Let me know if you are okay with that.

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

> 
>  arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
>  drivers/gpio/gpio-adp5588.c                    | 2 +-
>  drivers/input/keyboard/adp5588-keys.c          | 2 +-
>  include/linux/{i2c => platform_data}/adp5588.h | 0
>  4 files changed, 3 insertions(+), 3 deletions(-)
>  rename include/linux/{i2c => platform_data}/adp5588.h (100%)
> 
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index eaec7b4832a29a..24985e658c19cd 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -22,7 +22,7 @@
>  #include <linux/usb/isp1362.h>
>  #endif
>  #include <linux/i2c.h>
> -#include <linux/i2c/adp5588.h>
> +#include <linux/platform_data/adp5588.h>
>  #include <linux/etherdevice.h>
>  #include <linux/ata_platform.h>
>  #include <linux/irq.h>
> diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c
> index c0f718b1231727..e717f8dc39667c 100644
> --- a/drivers/gpio/gpio-adp5588.c
> +++ b/drivers/gpio/gpio-adp5588.c
> @@ -16,7 +16,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/irq.h>
>  
> -#include <linux/i2c/adp5588.h>
> +#include <linux/platform_data/adp5588.h>
>  
>  #define DRV_NAME	"adp5588-gpio"
>  
> diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
> index 53fe9a3fb6204d..f9d273c8b30695 100644
> --- a/drivers/input/keyboard/adp5588-keys.c
> +++ b/drivers/input/keyboard/adp5588-keys.c
> @@ -20,7 +20,7 @@
>  #include <linux/gpio.h>
>  #include <linux/slab.h>
>  
> -#include <linux/i2c/adp5588.h>
> +#include <linux/platform_data/adp5588.h>
>  
>  /* Key Event Register xy */
>  #define KEY_EV_PRESSED		(1 << 7)
> diff --git a/include/linux/i2c/adp5588.h b/include/linux/platform_data/adp5588.h
> similarity index 100%
> rename from include/linux/i2c/adp5588.h
> rename to include/linux/platform_data/adp5588.h
> -- 
> 2.11.0
> 

-- 
Dmitry