linux-kernel - Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fufxs19r.fsf@concordia.ellerman.id.au>
Date:   Mon, 22 May 2017 19:12:48 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Pavel Machek <pavel@...x.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, mark.rutland@....com,
        devicetree@...r.kernel.org, trivial@...nel.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org, paulus@...ba.org,
        Andrew Morton <akpm@...l.org>, jwboyer@...ux.vnet.ibm.com,
        sr@...x.de, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap

Pavel Machek <pavel@...x.de> writes:

> Hi!
>
>> >>> > > Signed-off-by: Pavel Machek <pavel@....cz>
>> >>> > 
>> >>> > Ping? Two partitions at same place are bad news...
>> >>> 
>> >>> Please expand on "bad news"?  What are the runtime effects of this
>> >>> change?  Decisions about which kernel(s) to patch depend on this info.
>> >>
>> >> Well... two partitions at same place. If you use one, you will corrupt
>> >> information on the other one.
>> >>
>> >> OTOH this moves partition around (so that they don't overlap) so it is
>> >> probably not stable candidate.
>> >>
>> >> I guess this is not huge issue; people using these boards probably
>> >> have custom dts changes, anyway...
>> >
>> > Or no one's even using it anymore.
>> >
>> > I can take this via powerpc, I won't mark it for stable etc.
>> 
>> It became:
>> 
>>     Author:     Pavel Machek <pavel@...x.de>
>> 
>>     powerpc/sequoia: Fix NAND partitions not to overlap
>>     
>>     Currently the DTS defines two partitions at the same addresses, if you
>>     use one, you will corrupt information on the other one. Fix it by
>>     shifting the second partition.
>>     
>>     Signed-off-by: Pavel Machek <pavel@....cz>
>>     [mpe: Reconstruct change log from email thread]
>>     Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
>> 
>> 
>> Minor nit, your From: address doesn't match your Signed-off-by: address,
>> which trips my "check patch is signed-off-by author" script. I can
>> just ignore it, but I think it's preferable if they match.
>
> Sorry about that (I have automatic scripts changing From:). It is
> still me, but I guess denx should get the credit here, so you can use.
>
> Signed-off-by: Pavel Machek <pavel@...x.de>

Sure, done.

cheers