linux-kernel - Re: [PATCH 1/1] printk: add __printf attributes to internal functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170522024616.GA4469@jagdpanzerIV.localdomain>
Date:   Mon, 22 May 2017 11:48:16 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] printk: add __printf attributes to internal functions

On (05/20/17 11:18), Nicolas Iooss wrote:
> When compiling with -Wsuggest-attribute=format, gcc complains that some
> functions in kernel/printk/printk_safe.c transmit their argument to
> printf-like functions without having a printf attribute. Silence these
> warnings by adding relevant __printf attributes.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>

no objections from my side.

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss