linux-kernel - Re: [PATCH v1] dmaengine: DW DMAC: Handle return value of clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170522104040.GF6510@vireshk-i7>
Date:   Mon, 22 May 2017 16:10:40 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     vireshk@...nel.org, andriy.shevchenko@...ux.intel.com,
        dan.j.williams@...el.com, vinod.koul@...el.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] dmaengine: DW DMAC: Handle return value of
 clk_prepare_enable

Create the patch using this command and the unnecessary "v1" in the
subject will go away:

$ git format-patch -C -M --thread=shallow

On 22-05-17, 16:01, Arvind Yadav wrote:
> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/dma/dw/platform.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> index c639c60..bc31fe8 100644
> --- a/drivers/dma/dw/platform.c
> +++ b/drivers/dma/dw/platform.c
> @@ -306,8 +306,12 @@ static int dw_resume_early(struct device *dev)
>  {
>  	struct platform_device *pdev = to_platform_device(dev);
>  	struct dw_dma_chip *chip = platform_get_drvdata(pdev);
> +	int ret;
> +
> +	ret = clk_prepare_enable(chip->clk);
> +	if (ret)
> +		return ret;
>  
> -	clk_prepare_enable(chip->clk);
>  	return dw_dma_enable(chip);
>  }

You don't need to resend it for now.

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh