linux-kernel - Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABe79T4_r0Was5AwFgrnkbazxe4txe9bU73L+rFJTZCC5o=u3g@mail.gmail.com>
Date:   Mon, 22 May 2017 19:03:17 +0530
From:   Srinath Mannam <srinath.mannam@...adcom.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Jon Mason <jonmason@...adcom.com>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with
 Multiblock read

On Mon, May 22, 2017 at 5:31 PM, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On 22 May 2017 at 13:52, Srinath Mannam <srinath.mannam@...adcom.com> wrote:
>> On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@...el.com> wrote:
>>> On 18/05/17 19:57, Srinath Mannam wrote:
>>>> The stingray SDHCI hardware supports ACMD12 and automatically
>>>> issues after multi block transfer completed.
>>>>
>>>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>>>> on multi block read command with below error message:
>>>>
>>>> Got data interrupt 0x00000002 even though no data
>>>> operation was in progress.
>>>>
>>>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>>>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>>>
>>>> Signed-off-by: Srinath Mannam <srinath.mannam@...adcom.com>
>>>> Reviewed-by: Ray Jui <ray.jui@...adcom.com>
>>>> Reviewed-by: Scott Branden <scott.branden@...adcom.com>
>>>
>>> Acked-by: Adrian Hunter <adrian.hunter@...el.com>
>>
>> Thanks Adrian...
>>
>> Will it be possible to take this for Linux-4.12??
>
> It's queued for 4.13, however are you saying it's a regression for
> 4.12? Then what commit fixes it?
>
> Perhaps you even want this to go stable?
>
> Kind regards
> Uffe

Yes, this is regression for 4.12.
Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
Yes we want this to go in stable.

Thank you.

Regards,
Srinath.