linux-kernel - Re: [PATCH] vhost: Coalesce vq_err formats, pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170522141646.GC1021@stefanha-x1.localdomain>
Date:   Mon, 22 May 2017 15:16:46 +0100
From:   Stefan Hajnoczi <stefanha@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vhost: Coalesce vq_err formats, pr_fmt misuse, add
 missing newlines

On Mon, May 22, 2017 at 03:33:43AM -0700, Joe Perches wrote:
> vhost logging uses of vq_err has a few defects and style inconsistencies.
> 
> o pr_debug already uses pr_fmt so its use in vq_err is defective
>   however no #defines of pr_fmt exist in this code so no actual
>   defects exist
> o vq_err uses need terminating newlines so add the missing ones
> o Coalesce formats and realign arguments
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/vhost/net.c   | 17 ++++++-------
>  drivers/vhost/scsi.c  | 17 ++++++-------
>  drivers/vhost/test.c  |  4 +--
>  drivers/vhost/vhost.c | 70 +++++++++++++++++++++++----------------------------
>  drivers/vhost/vhost.h | 11 ++++----
>  5 files changed, 54 insertions(+), 65 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)