linux-kernel - Re: RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e1a5d08-34a7-1b88-80ac-c650c4ae76cf@users.sourceforge.net>
Date:   Mon, 22 May 2017 16:32:58 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Sowmini Varadhan <sowmini.varadhan@...cle.com>,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        rds-devel@....oracle.com, kernel-janitors@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: RDS: TCP: Delete an error message for a failed memory allocation
 in rds_tcp_init_net()

>> Omit an extra message for a memory allocation failure in this function.
> 
> The change itself is harmless,  but I'm curious about the "extra"
> part: "extra" from what? If this happens, hopefully this will be logged
> somewhere? Note that this type of (infrequent) logging noise is useful
> in some cases, e.g., with 8ce675ff, when one is trying to do the
> post-mortem of where things first went wrong.

Do you find information from a Linux allocation failure report sufficient
for such an use case?

Regards,
Markus